Re: [PATCH v3 3/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()

2021-01-09 Thread Bin Meng
Hi Philippe, On Sun, Jan 10, 2021 at 7:53 AM Philippe Mathieu-Daudé wrote: > > On 1/9/21 1:35 PM, Bin Meng wrote: > > From: Bin Meng > > > > Usually the approach is that the device on the other end of the line > > is going to reset its state anyway, so there's no need to actively > > signal an i

Re: [PATCH v3 3/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()

2021-01-09 Thread Philippe Mathieu-Daudé
On 1/9/21 1:35 PM, Bin Meng wrote: > From: Bin Meng > > Usually the approach is that the device on the other end of the line > is going to reset its state anyway, so there's no need to actively > signal an irq line change during the reset hook. > > Move imx_spi_update_irq() out of imx_spi_reset(

[PATCH v3 3/6] hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()

2021-01-09 Thread Bin Meng
From: Bin Meng Usually the approach is that the device on the other end of the line is going to reset its state anyway, so there's no need to actively signal an irq line change during the reset hook. Move imx_spi_update_irq() out of imx_spi_reset(), along with the disabling of chip selects, to a