Re: [PATCH v3 3/3] capstone: Add s390x skipdata callback

2019-10-15 Thread Richard Henderson
On 10/15/19 11:46 AM, Thomas Huth wrote: >> +cap_skipdata_s390x_cb(const uint8_t *code, size_t code_size, >> + size_t offset, void *user_data) >> +{ >> +size_t ilen; >> + >> +/* See get_ilen() in target/s390x/internal.h. */ >> +switch (code[offset] >> 6) { >> +

Re: [PATCH v3 3/3] capstone: Add s390x skipdata callback

2019-10-15 Thread Thomas Huth
On 15/10/2019 19.51, Richard Henderson wrote: > Capstone assumes any unknown instruction is 2 bytes. > Instead, use the ilen field in the first two bits of > the instruction to stay in sync with the insn stream. > > Signed-off-by: Richard Henderson > --- > disas.c | 37 ++

[PATCH v3 3/3] capstone: Add s390x skipdata callback

2019-10-15 Thread Richard Henderson
Capstone assumes any unknown instruction is 2 bytes. Instead, use the ilen field in the first two bits of the instruction to stay in sync with the insn stream. Signed-off-by: Richard Henderson --- disas.c | 37 + 1 file changed, 37 insertions(+) diff --git a/