Re: [PATCH v3 24/25] nbd: Fix error_append_hint usage

2019-09-25 Thread Vladimir Sementsov-Ogievskiy
25.09.2019 0:12, Eric Blake wrote: > On 9/24/19 3:09 PM, Vladimir Sementsov-Ogievskiy wrote: >> If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro. >> Otherwise hint will not be appended in case of errp == &fatal_err >> (program will exit before error_append_hint() call). Fix suc

Re: [PATCH v3 24/25] nbd: Fix error_append_hint usage

2019-09-24 Thread Eric Blake
On 9/24/19 3:09 PM, Vladimir Sementsov-Ogievskiy wrote: > If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro. > Otherwise hint will not be appended in case of errp == &fatal_err > (program will exit before error_append_hint() call). Fix such cases. > Copy-and-pasted, but if you

[PATCH v3 24/25] nbd: Fix error_append_hint usage

2019-09-24 Thread Vladimir Sementsov-Ogievskiy
If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro. Otherwise hint will not be appended in case of errp == &fatal_err (program will exit before error_append_hint() call). Fix such cases. This commit (together with its neighbors) was generated by git grep -l 'error_append_hint(e