Re: [PATCH v3 21/49] semihosting: Use env more often in do_common_semihosting

2022-05-23 Thread Richard Henderson
On 5/23/22 05:53, Peter Maydell wrote: On Sat, 21 May 2022 at 01:04, Richard Henderson wrote: We've already loaded cs->env_ptr into a local variable; use it. Since env is unconditionally used, we don't need a dummy use. Signed-off-by: Richard Henderson --- target/arm/common-semi-target.h

Re: [PATCH v3 21/49] semihosting: Use env more often in do_common_semihosting

2022-05-23 Thread Peter Maydell
On Sat, 21 May 2022 at 01:04, Richard Henderson wrote: > > We've already loaded cs->env_ptr into a local variable; use it. > Since env is unconditionally used, we don't need a dummy use. > > Signed-off-by: Richard Henderson > --- > target/arm/common-semi-target.h | 62 ++ > ta

[PATCH v3 21/49] semihosting: Use env more often in do_common_semihosting

2022-05-20 Thread Richard Henderson
We've already loaded cs->env_ptr into a local variable; use it. Since env is unconditionally used, we don't need a dummy use. Signed-off-by: Richard Henderson --- target/arm/common-semi-target.h | 62 ++ target/riscv/common-semi-target.h | 50 +++ semihosting/arm-