> a) handle the QEMU_PLUGIN_CB_RW_REGS
I missed that this was not already handled. I'll fix that.
> b) try and enforce we are only being called from such callbacks
Sure, beyond documentation I suppose we can add and check a flag to ensure
this. I think it's a good idea to reduce foot guns from
Rowan Hart writes:
> From: novafacing
>
> Signed-off-by: novafacing
> Signed-off-by: Rowan Hart
> ---
> include/qemu/qemu-plugin.h | 57 +-
> plugins/api.c | 26 -
> 2 files changed, 56 insertions(+), 27 deletions(-)
>
> diff --
Hi Rowan,
May 22, 2025 at 5:02 PM, Rowan Hart wrote:
> > Again, what was the reason for moving `qemu_plugin_read_register`?
>
> I moved it so it's grouped with get_registers above instead of being
> separated below the memory functions. I can move it back, just seemed nicer
> that way.
The mov
Hi Julian,
> Again, what was the reason for moving `qemu_plugin_read_register`?
I moved it so it's grouped with get_registers above instead of being
separated below the memory functions. I can move it back, just seemed nicer
that way.
-Rowan
On Thu, May 22, 2025, 4:59 AM Julian Ganz wrote:
>
Hi Rowan,
> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
> index 3a850aa216..68c8632fd7 100644
> --- a/include/qemu/qemu-plugin.h
> +++ b/include/qemu/qemu-plugin.h
> @@ -893,6 +891,41 @@ typedef struct {
> QEMU_PLUGIN_API
> GArray *qemu_plugin_get_registers(void);
>
> +
On 5/21/25 2:43 AM, Rowan Hart wrote:
From: novafacing
Signed-off-by: novafacing
Signed-off-by: Rowan Hart
---
include/qemu/qemu-plugin.h | 57 +-
plugins/api.c | 26 -
2 files changed, 56 insertions(+), 27 deletions(-)
Re
From: novafacing
Signed-off-by: novafacing
Signed-off-by: Rowan Hart
---
include/qemu/qemu-plugin.h | 57 +-
plugins/api.c | 26 -
2 files changed, 56 insertions(+), 27 deletions(-)
diff --git a/include/qemu/qemu-plugin.h b/incl
