Re: [PATCH v3 2/4] qemu-img: validate image length in img_map

2020-05-13 Thread Eric Blake
On 5/13/20 8:36 AM, Eyal Moscovici wrote: The code handles this case correctly we merely skip the loop. However it Grammar suggestion: s/correctly we/correctly: we/ is probably best to return an explicit error. Reviewed-by: Eric Blake R-b still stands. Acked-by: Mark Kanda Signed-off-b

[PATCH v3 2/4] qemu-img: validate image length in img_map

2020-05-13 Thread Eyal Moscovici
The code handles this case correctly we merely skip the loop. However it is probably best to return an explicit error. Reviewed-by: Eric Blake Acked-by: Mark Kanda Signed-off-by: Eyal Moscovici --- qemu-img.c | 5 + 1 file changed, 5 insertions(+) diff --git a/qemu-img.c b/qemu-img.c inde