Re: [PATCH v3 2/3] util/main-loop: Avoid adding the same HANDLE twice

2022-10-19 Thread Bin Meng
Hi Daniel, On Wed, Oct 19, 2022 at 4:32 PM Daniel P. Berrangé wrote: > > On Wed, Aug 24, 2022 at 04:52:30PM +0800, Bin Meng wrote: > > From: Bin Meng > > > > Fix the logic in qemu_add_wait_object() to avoid adding the same > > HANDLE twice, as the behavior is undefined when passing an array > >

Re: [PATCH v3 2/3] util/main-loop: Avoid adding the same HANDLE twice

2022-10-19 Thread Daniel P . Berrangé
On Wed, Aug 24, 2022 at 04:52:30PM +0800, Bin Meng wrote: > From: Bin Meng > > Fix the logic in qemu_add_wait_object() to avoid adding the same > HANDLE twice, as the behavior is undefined when passing an array > that contains same HANDLEs to WaitForMultipleObjects() API. Have you encountered th

Re: [PATCH v3 2/3] util/main-loop: Avoid adding the same HANDLE twice

2022-08-30 Thread Philippe Mathieu-Daudé via
On 24/8/22 10:52, Bin Meng wrote: From: Bin Meng Fix the logic in qemu_add_wait_object() to avoid adding the same HANDLE twice, as the behavior is undefined when passing an array that contains same HANDLEs to WaitForMultipleObjects() API. Signed-off-by: Bin Meng --- Changes in v3: - new patc

[PATCH v3 2/3] util/main-loop: Avoid adding the same HANDLE twice

2022-08-24 Thread Bin Meng
From: Bin Meng Fix the logic in qemu_add_wait_object() to avoid adding the same HANDLE twice, as the behavior is undefined when passing an array that contains same HANDLEs to WaitForMultipleObjects() API. Signed-off-by: Bin Meng --- Changes in v3: - new patch: avoid adding the same HANDLE twic