Re: [PATCH v3 2/3] scripts/qapi-gen.py: add --add-trace-events option

2022-01-19 Thread Paolo Bonzini
On 1/18/22 15:22, Markus Armbruster wrote: So, supporting auto-generated trace points for qga qmp commands requires some deeper refactoring. Similar trouble with tests? The normal case seems to be "generate trace code", with an exception for cases where our build system defeats that. Agree?

Re: [PATCH v3 2/3] scripts/qapi-gen.py: add --add-trace-events option

2022-01-18 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 18.01.2022 13:27, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Add and option to generate trace events. We should generate both trace >>> events and trace-events files for further trace events code generation. >> >> Can you expl

Re: [PATCH v3 2/3] scripts/qapi-gen.py: add --add-trace-events option

2022-01-18 Thread Vladimir Sementsov-Ogievskiy
18.01.2022 13:27, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add and option to generate trace events. We should generate both trace events and trace-events files for further trace events code generation. Can you explain why we want trace generation to be optional? Becaus

Re: [PATCH v3 2/3] scripts/qapi-gen.py: add --add-trace-events option

2022-01-18 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Add and option to generate trace events. We should generate both trace > events and trace-events files for further trace events code generation. Can you explain why we want trace generation to be optional? > Signed-off-by: Vladimir Sementsov-Ogievskiy > -

[PATCH v3 2/3] scripts/qapi-gen.py: add --add-trace-events option

2022-01-17 Thread Vladimir Sementsov-Ogievskiy
Add and option to generate trace events. We should generate both trace events and trace-events files for further trace events code generation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/qapi/commands.py | 91 ++-- scripts/qapi/main.py | 10 +++