Re: [PATCH v3 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-20 Thread Igor Mammedov
On Thu, 17 Feb 2022 19:02:05 +0530 (IST) Ani Sinha wrote: > On Thu, 17 Feb 2022, Igor Mammedov wrote: > > > On Mon, 14 Feb 2022 19:42:35 +0530 > > > > > > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2023977 > > s/buglink/Resolves/ > > > > OK I am curious about this one. > > P

Re: [PATCH v3 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-17 Thread Ani Sinha
On Thu, 17 Feb 2022, Igor Mammedov wrote: > On Mon, 14 Feb 2022 19:42:35 +0530 > > > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2023977 > s/buglink/Resolves/ > OK I am curious about this one. Per https://www.qemu.org/docs/master/devel/submitting-a-patch.html , If your patch fixes

Re: [PATCH v3 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-17 Thread Igor Mammedov
On Mon, 14 Feb 2022 19:42:35 +0530 Ani Sinha wrote: > The current smbios table implementation splits the main memory in 16 GiB > (DIMM like) chunks. With the current smbios table assignment code, we can have > only 512 such chunks before the 16 bit handle numbers in the header for tables > 17 and

[PATCH v3 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-14 Thread Ani Sinha
The current smbios table implementation splits the main memory in 16 GiB (DIMM like) chunks. With the current smbios table assignment code, we can have only 512 such chunks before the 16 bit handle numbers in the header for tables 17 and 19 conflict. A guest with more than 8 TiB of memory will hit