Re: [PATCH v3 2/3] bsd-user: Propagate alignment argument to mmap_find_vma()

2025-03-09 Thread Warner Losh
On Fri, Mar 7, 2025 at 6:10 AM Philippe Mathieu-Daudé wrote: > Propagate the alignment to mmap_find_vma(), effectively > embedding mmap_find_vma_aligned() within mmap_find_vma(). > > Since we ignore the alignment in do_bsd_shmat(), leave a > FIXME comment. > > Signed-off-by: Philippe Mathieu-Daud

Re: [PATCH v3 2/3] bsd-user: Propagate alignment argument to mmap_find_vma()

2025-03-07 Thread Philippe Mathieu-Daudé
On 7/3/25 17:08, Richard Henderson wrote: On 3/7/25 05:09, Philippe Mathieu-Daudé wrote: Propagate the alignment to mmap_find_vma(), effectively embedding mmap_find_vma_aligned() within mmap_find_vma(). Since we ignore the alignment in do_bsd_shmat(), leave a FIXME comment. Signed-off-by: Phil

Re: [PATCH v3 2/3] bsd-user: Propagate alignment argument to mmap_find_vma()

2025-03-07 Thread Richard Henderson
On 3/7/25 05:09, Philippe Mathieu-Daudé wrote: Propagate the alignment to mmap_find_vma(), effectively embedding mmap_find_vma_aligned() within mmap_find_vma(). Since we ignore the alignment in do_bsd_shmat(), leave a FIXME comment. Signed-off-by: Philippe Mathieu-Daudé --- bsd-user/bsd-mem.

[PATCH v3 2/3] bsd-user: Propagate alignment argument to mmap_find_vma()

2025-03-07 Thread Philippe Mathieu-Daudé
Propagate the alignment to mmap_find_vma(), effectively embedding mmap_find_vma_aligned() within mmap_find_vma(). Since we ignore the alignment in do_bsd_shmat(), leave a FIXME comment. Signed-off-by: Philippe Mathieu-Daudé --- bsd-user/bsd-mem.h | 2 +- bsd-user/qemu.h| 2 +- bsd-user/mm