Re: [PATCH v3 2/2] virtio-blk: Convert QEMUBH callback to "bitops.h" API

2021-05-21 Thread Stefan Hajnoczi
On Mon, May 10, 2021 at 10:07:58PM +0200, Philippe Mathieu-Daudé wrote: > By directly using find_first_bit() and find_next_bit from the > "bitops.h" API to iterate over the bitmap, we can remove the > bitmap[] variable-length array copy on the stack and the complex > manual bit testing/clearing log

[PATCH v3 2/2] virtio-blk: Convert QEMUBH callback to "bitops.h" API

2021-05-10 Thread Philippe Mathieu-Daudé
By directly using find_first_bit() and find_next_bit from the "bitops.h" API to iterate over the bitmap, we can remove the bitmap[] variable-length array copy on the stack and the complex manual bit testing/clearing logic. Suggested-by: Stefan Hajnoczi Suggested-by: Richard Henderson Reviewed-by