Re: [PATCH v3 13/16] qapi/expr.py: Modify check_keys to accept any Collection

2021-02-25 Thread Markus Armbruster
John Snow writes: > This is a minor adjustment that allows the 'required' and 'optional' > keys fields to take a default value of an empty, immutable sequence (the > empty tuple). Quite marginal, but simple enough for me not to say no to it. > This reveals a quirk of this function, which is tha

[PATCH v3 13/16] qapi/expr.py: Modify check_keys to accept any Collection

2021-02-22 Thread John Snow
This is a minor adjustment that allows the 'required' and 'optional' keys fields to take a default value of an empty, immutable sequence (the empty tuple). This reveals a quirk of this function, which is that "a + b" is list-specific behavior. We can accept a wider variety of types if we avoid tha