Re: [PATCH v3 12/34] qapi: Add feature flags to remaining definitions

2020-03-17 Thread Eric Blake
On 3/17/20 12:46 AM, Markus Armbruster wrote: +++ b/tests/qapi-schema/doc-good.json @@ -53,10 +53,14 @@ # @Enum: # @one: The _one_ {and only} # +# Features: +# @enum-feat: Also _one_ {and only} +# # @two is undocumented ## { 'enum': 'Enum', 'data': [ { 'name':

Re: [PATCH v3 12/34] qapi: Add feature flags to remaining definitions

2020-03-16 Thread Markus Armbruster
Eric Blake writes: > On 3/15/20 9:46 AM, Markus Armbruster wrote: >> In v4.1.0, we added feature flags just to struct types (commit >> 6a8c0b5102^..f3ed93d545), to satisfy an immediate need (commit >> c9d4070991 "file-posix: Add dynamic-auto-read-only QAPI feature"). In >> v4.2.0, we added them

Re: [PATCH v3 12/34] qapi: Add feature flags to remaining definitions

2020-03-16 Thread Eric Blake
On 3/15/20 9:46 AM, Markus Armbruster wrote: In v4.1.0, we added feature flags just to struct types (commit 6a8c0b5102^..f3ed93d545), to satisfy an immediate need (commit c9d4070991 "file-posix: Add dynamic-auto-read-only QAPI feature"). In v4.2.0, we added them to commands (commit 23394b4c39 "q

[PATCH v3 12/34] qapi: Add feature flags to remaining definitions

2020-03-15 Thread Markus Armbruster
In v4.1.0, we added feature flags just to struct types (commit 6a8c0b5102^..f3ed93d545), to satisfy an immediate need (commit c9d4070991 "file-posix: Add dynamic-auto-read-only QAPI feature"). In v4.2.0, we added them to commands (commit 23394b4c39 "qapi: Add feature flags to commands") to satisfy