RE: [PATCH v3 12/20] virtio-gpu: Add virtio_gpu_set_scanout_blob

2021-05-11 Thread Kasireddy, Vivek
Hi Gerd, > > -pixman_image_unref(res->image); > > +if (res->image) { > > +pixman_image_unref(res->image); > > +} > > There is qemu_pixman_image_unref(). > > Like pixman_image_unref except that it also accepts (and ignores) NULL > pointers. [Kasireddy, Vivek] Made the change i

Re: [PATCH v3 12/20] virtio-gpu: Add virtio_gpu_set_scanout_blob

2021-05-11 Thread Gerd Hoffmann
Hi, > -pixman_image_unref(res->image); > +if (res->image) { > +pixman_image_unref(res->image); > +} There is qemu_pixman_image_unref(). Like pixman_image_unref except that it also accepts (and ignores) NULL pointers. > virtio_gpu_cleanup_mapping(g, res); > QTAILQ

[PATCH v3 12/20] virtio-gpu: Add virtio_gpu_set_scanout_blob

2021-05-11 Thread Vivek Kasireddy
This API allows Qemu to set the blob allocated by the Guest as the scanout buffer. If Opengl support is available, then the scanout buffer would be submitted as a dmabuf to the UI; if not, a pixman image is created from the scanout buffer and is submitted to the UI via the display surface. Based-o