Re: [PATCH v3 12/16] python/machine.py: Add _qmp access shim

2020-06-26 Thread John Snow
On 6/22/20 7:32 AM, Philippe Mathieu-Daudé wrote: > On 6/22/20 12:23 PM, Kevin Wolf wrote: >> Am 20.06.2020 um 10:20 hat Philippe Mathieu-Daudé geschrieben: >>> On Sat, Jun 20, 2020 at 10:14 AM Philippe Mathieu-Daudé >>> wrote: On 6/4/20 10:22 PM, John Snow wrote: > Like many ot

Re: [PATCH v3 12/16] python/machine.py: Add _qmp access shim

2020-06-22 Thread John Snow
On 6/22/20 6:23 AM, Kevin Wolf wrote: > Am 20.06.2020 um 10:20 hat Philippe Mathieu-Daudé geschrieben: >> On Sat, Jun 20, 2020 at 10:14 AM Philippe Mathieu-Daudé >> wrote: >>> >>> On 6/4/20 10:22 PM, John Snow wrote: Like many other Optional[] types, it's not always a given that this

Re: [PATCH v3 12/16] python/machine.py: Add _qmp access shim

2020-06-22 Thread Philippe Mathieu-Daudé
On 6/22/20 12:23 PM, Kevin Wolf wrote: > Am 20.06.2020 um 10:20 hat Philippe Mathieu-Daudé geschrieben: >> On Sat, Jun 20, 2020 at 10:14 AM Philippe Mathieu-Daudé >> wrote: >>> >>> On 6/4/20 10:22 PM, John Snow wrote: Like many other Optional[] types, it's not always a given that this

Re: [PATCH v3 12/16] python/machine.py: Add _qmp access shim

2020-06-22 Thread Kevin Wolf
Am 20.06.2020 um 10:20 hat Philippe Mathieu-Daudé geschrieben: > On Sat, Jun 20, 2020 at 10:14 AM Philippe Mathieu-Daudé > wrote: > > > > On 6/4/20 10:22 PM, John Snow wrote: > > > Like many other Optional[] types, it's not always a given that this > > > object will be set. Wrap it in a type-shi

Re: [PATCH v3 12/16] python/machine.py: Add _qmp access shim

2020-06-20 Thread Philippe Mathieu-Daudé
On Sat, Jun 20, 2020 at 10:14 AM Philippe Mathieu-Daudé wrote: > > On 6/4/20 10:22 PM, John Snow wrote: > > Like many other Optional[] types, it's not always a given that this > > object will be set. Wrap it in a type-shim that raises a meaningful > > error and will always return a concrete type.

Re: [PATCH v3 12/16] python/machine.py: Add _qmp access shim

2020-06-20 Thread Philippe Mathieu-Daudé
On 6/4/20 10:22 PM, John Snow wrote: > Like many other Optional[] types, it's not always a given that this > object will be set. Wrap it in a type-shim that raises a meaningful > error and will always return a concrete type. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 12 ++

[PATCH v3 12/16] python/machine.py: Add _qmp access shim

2020-06-04 Thread John Snow
Like many other Optional[] types, it's not always a given that this object will be set. Wrap it in a type-shim that raises a meaningful error and will always return a concrete type. Signed-off-by: John Snow --- python/qemu/machine.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletion