Re: [PATCH v3 11/26] target/arm/kvm-rme: Add measurement algorithm property

2024-11-26 Thread Daniel P . Berrangé
On Tue, Nov 26, 2024 at 04:11:19PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Nov 25, 2024 at 07:56:10PM +, Jean-Philippe Brucker wrote: > > [...] > > >> diff --git a/qapi/qom.json b/qapi/qom.json > >> index f982850bca..901ba67634 100644 > >> --- a/qapi/qom.j

Re: [PATCH v3 11/26] target/arm/kvm-rme: Add measurement algorithm property

2024-11-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Nov 25, 2024 at 07:56:10PM +, Jean-Philippe Brucker wrote: [...] >> diff --git a/qapi/qom.json b/qapi/qom.json >> index f982850bca..901ba67634 100644 >> --- a/qapi/qom.json >> +++ b/qapi/qom.json >> @@ -1068,6 +1068,20 @@ >>'data': { '*cpu-affinity':

Re: [PATCH v3 11/26] target/arm/kvm-rme: Add measurement algorithm property

2024-11-26 Thread Daniel P . Berrangé
On Mon, Nov 25, 2024 at 07:56:10PM +, Jean-Philippe Brucker wrote: > This option selects which measurement algorithm to use for attestation. > Supported values are SHA256 and SHA512. Default to SHA512 arbitrarily. I'd suggest that defaulting to sha256 is the better choice. sha512 is overkill

[PATCH v3 11/26] target/arm/kvm-rme: Add measurement algorithm property

2024-11-25 Thread Jean-Philippe Brucker
This option selects which measurement algorithm to use for attestation. Supported values are SHA256 and SHA512. Default to SHA512 arbitrarily. SHA512 is generally faster on 64-bit architectures. On a few arm64 CPUs I tested SHA256 is much faster, but that's most likely because they only support ac