Re: [PATCH v3 11/11] 9p: darwin: adjust assumption on virtio-9p-test

2022-01-28 Thread Christian Schoenebeck
On Freitag, 28. Januar 2022 14:38:43 CET Will Cohen wrote: > Apologies! The explanation (and what I'll include in v4) is below: > > The previous test depended on the assumption that P9_DOTL_AT_REMOVEDIR and > AT_REMOVEDIR have the same value. > > While this is true on Linux, it is not true everyw

Re: [PATCH v3 11/11] 9p: darwin: adjust assumption on virtio-9p-test

2022-01-28 Thread Will Cohen
Apologies! The explanation (and what I'll include in v4) is below: The previous test depended on the assumption that P9_DOTL_AT_REMOVEDIR and AT_REMOVEDIR have the same value. While this is true on Linux, it is not true everywhere, and leads to an incorrect test failure on unlink_at, noticed when

Re: [PATCH v3 11/11] 9p: darwin: adjust assumption on virtio-9p-test

2022-01-27 Thread Thomas Huth
-EMISSINGPATCHDESCRIPTION Please avoid sending patches without patch description. E.g. explain here *why* this needs to be adjusted. Thanks, Thomas On 28/01/2022 01.56, Will Cohen wrote: Signed-off-by: Fabian Franz Signed-off-by: Will Cohen --- tests/qtest/virtio-9p-test.c | 2 +-

[PATCH v3 11/11] 9p: darwin: adjust assumption on virtio-9p-test

2022-01-27 Thread Will Cohen
Signed-off-by: Fabian Franz Signed-off-by: Will Cohen --- tests/qtest/virtio-9p-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c index 41fed41de1..6bcf89f0f8 100644 --- a/tests/qtest/virtio-9p-test.c +++ b/test