Re: [PATCH v3 10/16] qapi/expr.py: Remove single-letter variable

2021-02-25 Thread John Snow
On 2/25/21 9:03 AM, Markus Armbruster wrote: Why? Is it to appease a style checker? I disagree with a blanket ban of single-letter variable names. If @f is deemed too terrible to live, then I'd prefer @feat over @feature, because it's more visually distant to @features. Yeah, pylint. We've ch

Re: [PATCH v3 10/16] qapi/expr.py: Remove single-letter variable

2021-02-25 Thread Markus Armbruster
Why? Is it to appease a style checker? I disagree with a blanket ban of single-letter variable names. If @f is deemed too terrible to live, then I'd prefer @feat over @feature, because it's more visually distant to @features. John Snow writes: > Signed-off-by: John Snow > Reviewed-by: Eduard

[PATCH v3 10/16] qapi/expr.py: Remove single-letter variable

2021-02-22 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 3235a3b809e..473ee4f7f7e 100644 --- a/scripts/qapi/expr.py