Re: [PATCH v3 1/9] qapi: replace List[str] by QAPISchemaIfCond

2021-05-17 Thread John Snow
On 5/17/21 7:17 AM, Marc-André Lureau wrote: Hi On Thu, May 13, 2021 at 12:53 AM John Snow > wrote: On 4/29/21 9:40 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau mailto:marcandre.lur...@redhat.com>>

Re: [PATCH v3 1/9] qapi: replace List[str] by QAPISchemaIfCond

2021-05-17 Thread Marc-André Lureau
Hi On Thu, May 13, 2021 at 12:53 AM John Snow wrote: > On 4/29/21 9:40 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Wrap the 'if' condition in a higher-level object. Not only this allows > > more type safety but also further refactoring without too much churn. > >

Re: [PATCH v3 1/9] qapi: replace List[str] by QAPISchemaIfCond

2021-05-12 Thread John Snow
On 4/29/21 9:40 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Wrap the 'if' condition in a higher-level object. Not only this allows more type safety but also further refactoring without too much churn. Would have done it myself if I had gotten to it first. I like having a

[PATCH v3 1/9] qapi: replace List[str] by QAPISchemaIfCond

2021-04-29 Thread marcandre . lureau
From: Marc-André Lureau Wrap the 'if' condition in a higher-level object. Not only this allows more type safety but also further refactoring without too much churn. The following patches will change the syntax of the schema 'if' conditions to be predicate expressions, and will generate code for