Re: [PATCH v3 1/8] Expose gdb_write_register function to consumers of gdbstub

2025-05-22 Thread Julian Ganz
Hi Rowan, > From: novafacing > > Signed-off-by: novafacing > Signed-off-by: Rowan Hart As I understand it, the commit subject should be prefixed with the subsystem the patch (mainly) touches. In this case "plugins". Commit message bodies would also be appreciated. In this case maybe one moti

Re: [PATCH v3 1/8] Expose gdb_write_register function to consumers of gdbstub

2025-05-22 Thread Manos Pitsidianakis
On Wed, May 21, 2025 at 12:45 PM Rowan Hart wrote: > > From: novafacing > > Signed-off-by: novafacing > Signed-off-by: Rowan Hart > --- > gdbstub/gdbstub.c | 2 +- > include/exec/gdbstub.h | 14 ++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/gdbstub/gd

Re: [PATCH v3 1/8] Expose gdb_write_register function to consumers of gdbstub

2025-05-21 Thread Pierrick Bouvier
On 5/21/25 2:43 AM, Rowan Hart wrote: From: novafacing Signed-off-by: novafacing Signed-off-by: Rowan Hart --- gdbstub/gdbstub.c | 2 +- include/exec/gdbstub.h | 14 ++ 2 files changed, 15 insertions(+), 1 deletion(-) Reviewed-by: Pierrick Bouvier

[PATCH v3 1/8] Expose gdb_write_register function to consumers of gdbstub

2025-05-21 Thread Rowan Hart
From: novafacing Signed-off-by: novafacing Signed-off-by: Rowan Hart --- gdbstub/gdbstub.c | 2 +- include/exec/gdbstub.h | 14 ++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 565f6b33a9..5846e481be 100644 --- a/gd