Re: [PATCH v3 1/7] net: Clarify early exit condition

2021-01-13 Thread Markus Armbruster
Eric Blake writes: > On first glance, the loop in qmp_query_rx_filter() has early return > paths that could leak any allocation of filter_list from a previous > iteration. But on closer inspection, it is obvious that all of the > early exits are guarded by has_name, and that the bulk of the loop

[PATCH v3 1/7] net: Clarify early exit condition

2020-12-23 Thread Eric Blake
On first glance, the loop in qmp_query_rx_filter() has early return paths that could leak any allocation of filter_list from a previous iteration. But on closer inspection, it is obvious that all of the early exits are guarded by has_name, and that the bulk of the loop body can be executed at most