Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 11:08:20AM +0200, Yuri Benditovich wrote: > Michael, just tell me please what you want: > You prefer to change everywhere ' virtio_net_config' to > 'virtio_net_config_rss' > and two month later to change it back? Exactly. > You prefer to change everywhere  ' virtio_net_co

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Yuri Benditovich
On Thu, Mar 12, 2020 at 10:23 AM Michael S. Tsirkin wrote: > On Thu, Mar 12, 2020 at 09:42:20AM +0200, Yuri Benditovich wrote: > > > > > > On Thu, Mar 12, 2020 at 9:21 AM Michael S. Tsirkin > wrote: > > > > On Thu, Mar 12, 2020 at 09:02:38AM +0200, Yuri Benditovich wrote: > > > >

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 09:42:20AM +0200, Yuri Benditovich wrote: > > > On Thu, Mar 12, 2020 at 9:21 AM Michael S. Tsirkin wrote: > > On Thu, Mar 12, 2020 at 09:02:38AM +0200, Yuri Benditovich wrote: > >     >     > +#define virtio_net_config virtio_net_config_with_rss > >     > >

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Yuri Benditovich
On Thu, Mar 12, 2020 at 9:21 AM Michael S. Tsirkin wrote: > On Thu, Mar 12, 2020 at 09:02:38AM +0200, Yuri Benditovich wrote: > > > > +#define virtio_net_config virtio_net_config_with_rss > > > > > > Do we have to? Let's just tweak code to do the right thing... > > > > >

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 09:02:38AM +0200, Yuri Benditovich wrote: > >     > +#define virtio_net_config virtio_net_config_with_rss > > > >     Do we have to? Let's just tweak code to do the right thing... > > > > > > Are we going to update the virtio_net some time? > > If

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Yuri Benditovich
On Wed, Mar 11, 2020 at 10:19 PM Michael S. Tsirkin wrote: > On Wed, Mar 11, 2020 at 03:57:58PM +0200, Yuri Benditovich wrote: > > > > > > On Wed, Mar 11, 2020 at 3:47 PM Michael S. Tsirkin > wrote: > > > > On Wed, Mar 11, 2020 at 02:35:13PM +0200, Yuri Benditovich wrote: > > > Signed-of

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2020 at 03:57:58PM +0200, Yuri Benditovich wrote: > > > On Wed, Mar 11, 2020 at 3:47 PM Michael S. Tsirkin wrote: > > On Wed, Mar 11, 2020 at 02:35:13PM +0200, Yuri Benditovich wrote: > > Signed-off-by: Yuri Benditovich > > --- > >  hw/net/virtio-net.c | 95

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-11 Thread Yuri Benditovich
On Wed, Mar 11, 2020 at 3:47 PM Michael S. Tsirkin wrote: > On Wed, Mar 11, 2020 at 02:35:13PM +0200, Yuri Benditovich wrote: > > Signed-off-by: Yuri Benditovich > > --- > > hw/net/virtio-net.c | 95 + > > 1 file changed, 95 insertions(+) > > > > diff

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2020 at 02:35:13PM +0200, Yuri Benditovich wrote: > Signed-off-by: Yuri Benditovich > --- > hw/net/virtio-net.c | 95 + > 1 file changed, 95 insertions(+) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 3627bb1717..95

[PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-11 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 95 + 1 file changed, 95 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 3627bb1717..9545b0e84f 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -71,6 +71