Re: [PATCH v3 1/6] hw/usb/hcd-xhci-pci: Use modulo to select MSI vector as per spec

2024-12-28 Thread Phil Dennis-Jordan
On Fri, 27 Dec 2024 at 21:27, Philippe Mathieu-Daudé wrote: > On 27/12/24 20:45, Phil Dennis-Jordan wrote: > > > > > > On Fri 27. Dec 2024 at 18:45, Philippe Mathieu-Daudé > > wrote: > > > > On 27/12/24 13:13, Phil Dennis-Jordan wrote: > > > QEMU would crash wi

Re: [PATCH v3 1/6] hw/usb/hcd-xhci-pci: Use modulo to select MSI vector as per spec

2024-12-27 Thread Philippe Mathieu-Daudé
On 27/12/24 20:45, Phil Dennis-Jordan wrote: On Fri 27. Dec 2024 at 18:45, Philippe Mathieu-Daudé > wrote: On 27/12/24 13:13, Phil Dennis-Jordan wrote: > QEMU would crash with a failed assertion if the XHCI controller > attempted to raise the interrupt

Re: [PATCH v3 1/6] hw/usb/hcd-xhci-pci: Use modulo to select MSI vector as per spec

2024-12-27 Thread Phil Dennis-Jordan
On Fri 27. Dec 2024 at 18:45, Philippe Mathieu-Daudé wrote: > On 27/12/24 13:13, Phil Dennis-Jordan wrote: > > QEMU would crash with a failed assertion if the XHCI controller > > attempted to raise the interrupt on a higher vector than the > > highest configured for the device by the guest driver

Re: [PATCH v3 1/6] hw/usb/hcd-xhci-pci: Use modulo to select MSI vector as per spec

2024-12-27 Thread Philippe Mathieu-Daudé
On 27/12/24 13:13, Phil Dennis-Jordan wrote: QEMU would crash with a failed assertion if the XHCI controller attempted to raise the interrupt on a higher vector than the highest configured for the device by the guest driver. It turns out the XHCI spec (Implementation Note in section 4.17, "Inter

[PATCH v3 1/6] hw/usb/hcd-xhci-pci: Use modulo to select MSI vector as per spec

2024-12-27 Thread Phil Dennis-Jordan
QEMU would crash with a failed assertion if the XHCI controller attempted to raise the interrupt on a higher vector than the highest configured for the device by the guest driver. It turns out the XHCI spec (Implementation Note in section 4.17, "Interrupters") requires that the host controller sig