Re: [PATCH v3 1/3] qtest: Add functions for accessing devices on Aspeed I2C controller

2023-03-28 Thread Stefan Berger
On 3/28/23 11:05, Thomas Huth wrote: On 28/03/2023 15.51, Stefan Berger wrote: + +void aspeed_i2c_writeb(uint32_t baseaddr, uint8_t slave_addr, +   uint8_t reg, uint8_t v) +{ +    aspeed_i2c_write_n(baseaddr, slave_addr, reg, v, sizeof(v)); +} For helper functions like

Re: [PATCH v3 1/3] qtest: Add functions for accessing devices on Aspeed I2C controller

2023-03-28 Thread Cédric Le Goater
+static void aspeed_i2c_write_n(uint32_t baseaddr, uint8_t slave_addr, +   uint8_t reg, uint32_t v, size_t nbytes) +{ +    size_t i; + +    aspeed_i2c_startup(baseaddr, slave_addr, reg); + +    for (i = 0; i < nbytes; i++) { +    writel(baseaddr + A_I2CD_BYTE_BUF,

Re: [PATCH v3 1/3] qtest: Add functions for accessing devices on Aspeed I2C controller

2023-03-28 Thread Thomas Huth
On 28/03/2023 15.51, Stefan Berger wrote: Add read and write functions for accessing registers of I2C devices connected to the Aspeed I2C controller. Signed-off-by: Stefan Berger Reviewed-by: Cédric Le Goater Reviewed-by: Ninad Palsule --- include/hw/i2c/aspeed_i2c.h | 7 +++ tests/qtest

[PATCH v3 1/3] qtest: Add functions for accessing devices on Aspeed I2C controller

2023-03-28 Thread Stefan Berger
Add read and write functions for accessing registers of I2C devices connected to the Aspeed I2C controller. Signed-off-by: Stefan Berger Reviewed-by: Cédric Le Goater Reviewed-by: Ninad Palsule --- include/hw/i2c/aspeed_i2c.h | 7 +++ tests/qtest/qtest_aspeed.c | 109 +++