Daniel P. Berrangé writes:
> On Tue, Feb 01, 2022 at 11:51:26AM +0100, Paolo Bonzini wrote:
>> On 1/31/22 20:43, Mark Kanda wrote:
>> >
>> > { "execute": "query-stats", "arguments" : { "target": "vm" } }
>> > { "return": {
>> > "list": [
>> >{ "provider": "kvm",
>> > "stats
On 2/3/22 19:12, Mark Kanda wrote:
I added the 'unknown' member here (and in other enums) to handle
situations where QEMU is behind KVM in terms of enumerating the various
stat types, units, etc. I feel this will be a semi-common scenario (old
QEMU on a new kernel) and with 'unknown', QEMU ca
On Thu, Feb 03, 2022 at 07:38:08PM +0100, Paolo Bonzini wrote:
> On 2/1/22 13:08, Daniel P. Berrangé wrote:
> > I still feel like this is rather verbose, and should be simplified
> > down to.
> >
> > { "return": {
> > "vm": {
> > "kvm": [ ... ]
> > "provider-XYZ": [ ... ],
On Thu, Feb 03, 2022 at 12:12:57PM -0600, Mark Kanda wrote:
> Thanks Daniel,
>
> On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote:
> > > +#
> > > +# Since: 7.0
> > > +##
> > > +{ 'enum' : 'StatType',
> > > + 'data' : [ 'cumulative', 'instant', 'peak',
> > > + 'linear-hist', 'log-hist', '
On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote:
+##
+# @StatsResults:
+#
+# Target specific results.
+#
+# Since: 7.0
+##
+{ 'union': 'StatsResults',
+ 'base': { 'target': 'StatsTarget' },
+ 'discriminator': 'target',
+ 'data': { 'vcpu': 'VCPUStatsResults',
+'vm': 'VMStatsResults' }
On 2/1/22 13:08, Daniel P. Berrangé wrote:
I still feel like this is rather verbose, and should be simplified
down to.
{ "return": {
"vm": {
"kvm": [ ... ]
"provider-XYZ": [ ... ],
...
}
}
My main qualm with this is that not just QEMU, but every layer ab
On 2/3/2022 12:30 PM, Daniel P. Berrangé wrote:
On Thu, Feb 03, 2022 at 12:12:57PM -0600, Mark Kanda wrote:
Thanks Daniel,
On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote:
+#
+# Since: 7.0
+##
+{ 'enum' : 'StatType',
+ 'data' : [ 'cumulative', 'instant', 'peak',
+ 'linear-hist',
Thanks Daniel,
On 2/1/2022 6:08 AM, Daniel P. Berrangé wrote:
+#
+# Since: 7.0
+##
+{ 'enum' : 'StatType',
+ 'data' : [ 'cumulative', 'instant', 'peak',
+ 'linear-hist', 'log-hist', 'unknown' ] }
IMHO 'unknown' shouldn't exist at all.
I added the 'unknown' member here (and in ot
On Mon, Jan 31, 2022 at 01:43:10PM -0600, Mark Kanda wrote:
> Introduce QMP support for querying stats. Provide a framework for adding new
> stats and support for the following commands:
>
> - query-stats
> Returns a list of all stats per target type (only VM and VCPU for now), with
> additional o
On Tue, Feb 01, 2022 at 11:51:26AM +0100, Paolo Bonzini wrote:
> On 1/31/22 20:43, Mark Kanda wrote:
> >
> > { "execute": "query-stats", "arguments" : { "target": "vm" } }
> > { "return": {
> > "list": [
> >{ "provider": "kvm",
> > "stats": [
> >{ "name": "max_mmu
On 1/31/22 20:43, Mark Kanda wrote:
{ "execute": "query-stats", "arguments" : { "target": "vm" } }
{ "return": {
"list": [
{ "provider": "kvm",
"stats": [
{ "name": "max_mmu_page_hash_collisions", "value": 0 },
{ "name": "max_mmu_rmap_size", "value": 0
Introduce QMP support for querying stats. Provide a framework for adding new
stats and support for the following commands:
- query-stats
Returns a list of all stats per target type (only VM and VCPU for now), with
additional options for specifying stat names, VCPU qom paths, and stat provider.
-
12 matches
Mail list logo
