Re: [PATCH v3 1/3] qemu-keymap: Free xkb allocations

2024-05-23 Thread Akihiko Odaki
On 2024/05/22 23:36, Peter Maydell wrote: On Wed, 22 May 2024 at 12:47, Daniel P. Berrangé wrote: On Wed, May 22, 2024 at 12:35:23PM +0100, Peter Maydell wrote: On Wed, 22 May 2024 at 11:49, Akihiko Odaki wrote: This fixes LeakSanitizer complaints with xkbcommon 1.6.0. Signed-off-by: Akih

Re: [PATCH v3 1/3] qemu-keymap: Free xkb allocations

2024-05-22 Thread Peter Maydell
On Wed, 22 May 2024 at 12:47, Daniel P. Berrangé wrote: > > On Wed, May 22, 2024 at 12:35:23PM +0100, Peter Maydell wrote: > > On Wed, 22 May 2024 at 11:49, Akihiko Odaki > > wrote: > > > > > > This fixes LeakSanitizer complaints with xkbcommon 1.6.0. > > > > > > Signed-off-by: Akihiko Odaki >

Re: [PATCH v3 1/3] qemu-keymap: Free xkb allocations

2024-05-22 Thread Daniel P . Berrangé
On Wed, May 22, 2024 at 12:35:23PM +0100, Peter Maydell wrote: > On Wed, 22 May 2024 at 11:49, Akihiko Odaki wrote: > > > > This fixes LeakSanitizer complaints with xkbcommon 1.6.0. > > > > Signed-off-by: Akihiko Odaki > > --- > > qemu-keymap.c | 3 +++ > > 1 file changed, 3 insertions(+) > > >

Re: [PATCH v3 1/3] qemu-keymap: Free xkb allocations

2024-05-22 Thread Michael Tokarev
22.05.2024 14:35, Peter Maydell wrote: ... This is surely a sanitizer bug. We're unconditionally about to exit() the program here, where everything is freed, so nothing is leaked. https://lists.nongnu.org/archive/html/qemu-devel/2024-05/msg00658.html fwiw. /mjt -- GPG Key transition (from rsa2

Re: [PATCH v3 1/3] qemu-keymap: Free xkb allocations

2024-05-22 Thread Peter Maydell
On Wed, 22 May 2024 at 11:49, Akihiko Odaki wrote: > > This fixes LeakSanitizer complaints with xkbcommon 1.6.0. > > Signed-off-by: Akihiko Odaki > --- > qemu-keymap.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qemu-keymap.c b/qemu-keymap.c > index 8c80f7a4ed65..7a9f38cf9863 100

[PATCH v3 1/3] qemu-keymap: Free xkb allocations

2024-05-22 Thread Akihiko Odaki
This fixes LeakSanitizer complaints with xkbcommon 1.6.0. Signed-off-by: Akihiko Odaki --- qemu-keymap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qemu-keymap.c b/qemu-keymap.c index 8c80f7a4ed65..7a9f38cf9863 100644 --- a/qemu-keymap.c +++ b/qemu-keymap.c @@ -237,6 +237,9 @@ int ma