Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-24 Thread Auger Eric
Hi Alex, On 9/24/19 1:05 AM, Alex Williamson wrote: > On Mon, 23 Sep 2019 08:55:51 +0200 > Eric Auger wrote: > >> The container error integer field is currently used to store >> the first error potentially encountered during any >> vfio_listener_region_add() call. However this fails to propagate

Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-23 Thread Peter Xu
On Mon, Sep 23, 2019 at 05:10:43PM -0600, Alex Williamson wrote: > On Mon, 23 Sep 2019 13:43:08 +0200 > Auger Eric wrote: > > > On 9/23/19 9:51 AM, Peter Xu wrote: > > > On Mon, Sep 23, 2019 at 08:55:51AM +0200, Eric Auger wrote: > > >> @@ -1308,9 +1319,9 @@ static int vfio_connect_container(VF

Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-23 Thread Alex Williamson
On Mon, 23 Sep 2019 13:43:08 +0200 Auger Eric wrote: > On 9/23/19 9:51 AM, Peter Xu wrote: > > On Mon, Sep 23, 2019 at 08:55:51AM +0200, Eric Auger wrote: > >> @@ -1308,9 +1319,9 @@ static int vfio_connect_container(VFIOGroup *group, > >> AddressSpace *as, > >>

Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-23 Thread Alex Williamson
On Mon, 23 Sep 2019 08:55:51 +0200 Eric Auger wrote: > The container error integer field is currently used to store > the first error potentially encountered during any > vfio_listener_region_add() call. However this fails to propagate > detailed error messages up to the vfio_connect_container ca

Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-23 Thread Auger Eric
Hi Peter, On 9/23/19 9:51 AM, Peter Xu wrote: > On Mon, Sep 23, 2019 at 08:55:51AM +0200, Eric Auger wrote: >> The container error integer field is currently used to store >> the first error potentially encountered during any >> vfio_listener_region_add() call. However this fails to propagate >> d

Re: [PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-23 Thread Peter Xu
On Mon, Sep 23, 2019 at 08:55:51AM +0200, Eric Auger wrote: > The container error integer field is currently used to store > the first error potentially encountered during any > vfio_listener_region_add() call. However this fails to propagate > detailed error messages up to the vfio_connect_contain

[PATCH v3 1/2] vfio: Turn the container error into an Error handle

2019-09-22 Thread Eric Auger
The container error integer field is currently used to store the first error potentially encountered during any vfio_listener_region_add() call. However this fails to propagate detailed error messages up to the vfio_connect_container caller. Instead of using an integer, let's use an Error handle.