Re: [PATCH v3 1/2] hw/riscv: Add fw_cfg support to virt

2021-03-18 Thread Asherah Connor
Hi Alistair, On 21/03/18 05:03:p, Alistair Francis wrote: > I'm guessing the failure is because of "hw/riscv: migrate fdt field to > generic MachineState" which moved the fdt element to the MachineState. > > The fix should just be to change s->fdt to mc->fdt. Yes, looks like it. I'll fix it up

Re: [PATCH v3 1/2] hw/riscv: Add fw_cfg support to virt

2021-03-18 Thread Alistair Francis
On Thu, Mar 18, 2021 at 5:25 PM Alistair Francis wrote: > > On Sun, Feb 28, 2021 at 6:17 AM Asherah Connor wrote: > > > > Provides fw_cfg for the virt machine on riscv. This enables > > using e.g. ramfb later. > > > > Signed-off-by: Asherah Connor > > This patch doesn't compile, I see this err

Re: [PATCH v3 1/2] hw/riscv: Add fw_cfg support to virt

2021-03-18 Thread Alistair Francis
On Sun, Feb 28, 2021 at 6:17 AM Asherah Connor wrote: > > Provides fw_cfg for the virt machine on riscv. This enables > using e.g. ramfb later. > > Signed-off-by: Asherah Connor This patch doesn't compile, I see this error: ../hw/riscv/virt.c: In function ‘create_fw_cfg’: ../hw/riscv/virt.c:5

Re: [PATCH v3 1/2] hw/riscv: Add fw_cfg support to virt

2021-03-03 Thread Alistair Francis
On Sun, Feb 28, 2021 at 6:45 AM Bin Meng wrote: > > On Sun, Feb 28, 2021 at 7:17 PM Asherah Connor wrote: > > > > Provides fw_cfg for the virt machine on riscv. This enables > > using e.g. ramfb later. > > > > Signed-off-by: Asherah Connor Reviewed-by: Alistair Francis Alistair > > --- > >

Re: [PATCH v3 1/2] hw/riscv: Add fw_cfg support to virt

2021-02-28 Thread Bin Meng
On Sun, Feb 28, 2021 at 7:17 PM Asherah Connor wrote: > > Provides fw_cfg for the virt machine on riscv. This enables > using e.g. ramfb later. > > Signed-off-by: Asherah Connor > --- > > Changes in v3: > * Document why fw_cfg is done when it is. > * Move VIRT_FW_CFG before VIRT_FLASH. > > Chan

[PATCH v3 1/2] hw/riscv: Add fw_cfg support to virt

2021-02-28 Thread Asherah Connor
Provides fw_cfg for the virt machine on riscv. This enables using e.g. ramfb later. Signed-off-by: Asherah Connor --- Changes in v3: * Document why fw_cfg is done when it is. * Move VIRT_FW_CFG before VIRT_FLASH. Changes in v2: * Add DMA support (needed for writes). hw/riscv/Kconfig