Re: [PATCH v3 09/66] target/ppc: Move SPR_DSISR setting to powerpc_excp

2021-08-19 Thread Richard Henderson
On 8/19/21 5:39 AM, Peter Maydell wrote: cpu_ldl_code() in the unaligned-access handler is strictly speaking bogus, because the page might have been unmapped after translation but before we got round to actually running it. Better would be to stash the relevant bits of info from the insn in the i

Re: [PATCH v3 09/66] target/ppc: Move SPR_DSISR setting to powerpc_excp

2021-08-19 Thread Peter Maydell
On Wed, 18 Aug 2021 at 20:24, Richard Henderson wrote: > > By doing this while sending the exception, we will have already > done the unwinding, which makes the ppc_cpu_do_unaligned_access > code a bit cleaner. > > Update the comment about the expected instruction format. > > Signed-off-by: Richar

[PATCH v3 09/66] target/ppc: Move SPR_DSISR setting to powerpc_excp

2021-08-18 Thread Richard Henderson
By doing this while sending the exception, we will have already done the unwinding, which makes the ppc_cpu_do_unaligned_access code a bit cleaner. Update the comment about the expected instruction format. Signed-off-by: Richard Henderson --- target/ppc/excp_helper.c | 21 +