Re: [PATCH v3 09/19] pc-bios/s390-ccw: Remove panics from SCSI IPL path

2024-10-09 Thread Jared Rossi
On 10/9/24 7:18 AM, Thomas Huth wrote: On 08/10/2024 03.15, jro...@linux.ibm.com wrote: +    if (!vs_io_assert(virtio_run(vdev, VR_REQUEST, cmd) == 0, title)) { +    puts(title); Should there be a "return" with a non-0 value here? ... +    } + +    return 0;   }     /* SCSI protocol i

Re: [PATCH v3 09/19] pc-bios/s390-ccw: Remove panics from SCSI IPL path

2024-10-09 Thread Thomas Huth
On 08/10/2024 03.15, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from virtio-scsi IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- ... @@ -78,

[PATCH v3 09/19] pc-bios/s390-ccw: Remove panics from SCSI IPL path

2024-10-07 Thread jrossi
From: Jared Rossi Remove panic-on-error from virtio-scsi IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/s390-ccw/bootmap.c | 88 +- pc-b