Re: [PATCH v3 09/14] migration/multifd: Isolate ram pages packet data

2024-08-22 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Aug 22, 2024 at 11:13:36AM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Thu, Aug 01, 2024 at 09:35:11AM -0300, Fabiano Rosas wrote: >> >> @@ -1554,7 +1577,6 @@ static void *multifd_recv_thread(void *opaque) >> >> qemu_sem_wait(&p->sem_sy

Re: [PATCH v3 09/14] migration/multifd: Isolate ram pages packet data

2024-08-22 Thread Peter Xu
On Thu, Aug 22, 2024 at 11:13:36AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Thu, Aug 01, 2024 at 09:35:11AM -0300, Fabiano Rosas wrote: > >> @@ -1554,7 +1577,6 @@ static void *multifd_recv_thread(void *opaque) > >> qemu_sem_wait(&p->sem_sync); > >> } >

Re: [PATCH v3 09/14] migration/multifd: Isolate ram pages packet data

2024-08-22 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Aug 01, 2024 at 09:35:11AM -0300, Fabiano Rosas wrote: >> @@ -1554,7 +1577,6 @@ static void *multifd_recv_thread(void *opaque) >> qemu_sem_wait(&p->sem_sync); >> } >> } else { >> -p->total_normal_pages += p->data->size

Re: [PATCH v3 09/14] migration/multifd: Isolate ram pages packet data

2024-08-21 Thread Peter Xu
On Thu, Aug 01, 2024 at 09:35:11AM -0300, Fabiano Rosas wrote: > @@ -1554,7 +1577,6 @@ static void *multifd_recv_thread(void *opaque) > qemu_sem_wait(&p->sem_sync); > } > } else { > -p->total_normal_pages += p->data->size / qemu_target_page_size();

[PATCH v3 09/14] migration/multifd: Isolate ram pages packet data

2024-08-01 Thread Fabiano Rosas
While we cannot yet disentangle the multifd packet from page data, we can make the code a bit cleaner by setting the page-related fields in a separate function. Signed-off-by: Fabiano Rosas --- migration/multifd.c| 110 - migration/trace-events | 9 +