Re: [PATCH v3 08/20] gdbstub: extend GByteArray to read register helpers

2019-12-19 Thread Alex Bennée
Damien Hedde writes: > Hi Alex, > > On 12/11/19 6:05 PM, Alex Bennée wrote: >> Instead of passing a pointer to memory now just extend the GByteArray >> to all the read register helpers. They can then safely append their >> data through the normal way. We don't bother with this abstraction for >

Re: [PATCH v3 08/20] gdbstub: extend GByteArray to read register helpers

2019-12-11 Thread Richard Henderson
On 12/11/19 9:05 AM, Alex Bennée wrote: > Instead of passing a pointer to memory now just extend the GByteArray > to all the read register helpers. They can then safely append their > data through the normal way. We don't bother with this abstraction for > write registers as we have already ensured

Re: [PATCH v3 08/20] gdbstub: extend GByteArray to read register helpers

2019-12-11 Thread Damien Hedde
Hi Alex, On 12/11/19 6:05 PM, Alex Bennée wrote: > Instead of passing a pointer to memory now just extend the GByteArray > to all the read register helpers. They can then safely append their > data through the normal way. We don't bother with this abstraction for > write registers as we have alr

[PATCH v3 08/20] gdbstub: extend GByteArray to read register helpers

2019-12-11 Thread Alex Bennée
Instead of passing a pointer to memory now just extend the GByteArray to all the read register helpers. They can then safely append their data through the normal way. We don't bother with this abstraction for write registers as we have already ensured the buffer being copied from is the correct siz