Re: [PATCH v3 08/20] cputlb: Disable __always_inline__ without optimization

2019-09-23 Thread Richard Henderson
On 9/23/19 9:49 AM, Paolo Bonzini wrote: > Hmm, still we support 4.8 and always_inline is much older than that. So > I'm not sure it's useful to test it. Fair enough. r~

Re: [PATCH v3 08/20] cputlb: Disable __always_inline__ without optimization

2019-09-23 Thread Paolo Bonzini
On 23/09/19 18:00, Richard Henderson wrote: > On 9/23/19 2:45 AM, Paolo Bonzini wrote: >> On 22/09/19 05:54, Richard Henderson wrote: >>> +/* >>> + * Forced inlining may be desired to encourage constant propagation >>> + * of function parameters. However, it can also make debugging harder, >>> + *

Re: [PATCH v3 08/20] cputlb: Disable __always_inline__ without optimization

2019-09-23 Thread Richard Henderson
On 9/23/19 2:45 AM, Paolo Bonzini wrote: > On 22/09/19 05:54, Richard Henderson wrote: >> +/* >> + * Forced inlining may be desired to encourage constant propagation >> + * of function parameters. However, it can also make debugging harder, >> + * so disable it for a non-optimizing build. >> + */

Re: [PATCH v3 08/20] cputlb: Disable __always_inline__ without optimization

2019-09-23 Thread Paolo Bonzini
On 22/09/19 05:54, Richard Henderson wrote: > +/* > + * Forced inlining may be desired to encourage constant propagation > + * of function parameters. However, it can also make debugging harder, > + * so disable it for a non-optimizing build. > + */ > +#if defined(__OPTIMIZE__) && __has_attribute(

Re: [PATCH v3 08/20] cputlb: Disable __always_inline__ without optimization

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/22/19 5:54 AM, Richard Henderson wrote: > This forced inlining can result in missing symbols, > which makes a debugging build harder to follow. > > Reviewed-by: David Hildenbrand > Reported-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > include/qemu/compiler.h | 11 +

[PATCH v3 08/20] cputlb: Disable __always_inline__ without optimization

2019-09-21 Thread Richard Henderson
This forced inlining can result in missing symbols, which makes a debugging build harder to follow. Reviewed-by: David Hildenbrand Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- include/qemu/compiler.h | 11 +++ accel/tcg/cputlb.c | 4 ++-- 2 files changed, 13 in