Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check

2021-07-19 Thread Philippe Mathieu-Daudé
On 7/18/21 12:18 AM, Richard Henderson wrote: > Since 0b00b0c1e05b, tb->size must not be zero. > Advance pc so that the breakpoint covers the insn at the bp. > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/489 > Signed-off-by: Richard Henderson > --- > target/avr/translate.c | 1 + >

Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check

2021-07-18 Thread Philippe Mathieu-Daudé
On 7/18/21 12:18 AM, Richard Henderson wrote: > Since 0b00b0c1e05b, tb->size must not be zero. > Advance pc so that the breakpoint covers the insn at the bp. > > Signed-off-by: Richard Henderson > --- > target/avr/translate.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu

Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check

2021-07-17 Thread Peter Maydell
On Sat, 17 Jul 2021 at 23:18, Richard Henderson wrote: > > Since 0b00b0c1e05b, tb->size must not be zero. > Advance pc so that the breakpoint covers the insn at the bp. > > Signed-off-by: Richard Henderson > --- > target/avr/translate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ta

[PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check

2021-07-17 Thread Richard Henderson
Since 0b00b0c1e05b, tb->size must not be zero. Advance pc so that the breakpoint covers the insn at the bp. Signed-off-by: Richard Henderson --- target/avr/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/avr/translate.c b/target/avr/translate.c index 8237a03c23..d768063d65