Markus Armbruster writes:
[...]
> I'd like to tighten the restriction instead: conditional arguments
> require boxed. Less ugly and less awkward to document, I think.
I had a look, and realized that doing it right will be a bit more
involved than I thought, since a couple of test cases need fi
Daniel P. Berrangé writes:
> On Thu, Mar 02, 2023 at 07:58:28AM +0100, Markus Armbruster wrote:
>> Marc-André Lureau writes:
>>
>> > Hi
>> >
>> > On Wed, Mar 1, 2023 at 5:16 PM Markus Armbruster wrote:
>> >> What about 3. have an additional command conditional on CONFIG_WIN32?
>> >> Existing g
On Thu, Mar 02, 2023 at 07:58:28AM +0100, Markus Armbruster wrote:
> Marc-André Lureau writes:
>
> > Hi
> >
> > On Wed, Mar 1, 2023 at 5:16 PM Markus Armbruster wrote:
> >> What about 3. have an additional command conditional on CONFIG_WIN32?
> >> Existing getfd stays the same: always fails when
Marc-André Lureau writes:
> Hi
>
> On Wed, Mar 1, 2023 at 5:16 PM Markus Armbruster wrote:
>> What about 3. have an additional command conditional on CONFIG_WIN32?
>> Existing getfd stays the same: always fails when QEMU runs on a Windows
>> host. The new command exists only when QEMU runs on a
Hi
On Wed, Mar 1, 2023 at 5:16 PM Markus Armbruster wrote:
> What about 3. have an additional command conditional on CONFIG_WIN32?
> Existing getfd stays the same: always fails when QEMU runs on a Windows
> host. The new command exists only when QEMU runs on a Windows host.
This is what was sug
Daniel P. Berrangé writes:
> On Tue, Feb 28, 2023 at 09:58:01AM -0600, Eric Blake wrote:
>> On Wed, Feb 22, 2023 at 11:23:03AM +0100, Markus Armbruster wrote:
>> > > However, I think it would be simpler, and better, if we piped the
>> > > generated code to clang-format (when available). I made a
On Tue, Feb 28, 2023 at 09:58:01AM -0600, Eric Blake wrote:
> On Wed, Feb 22, 2023 at 11:23:03AM +0100, Markus Armbruster wrote:
> > > However, I think it would be simpler, and better, if we piped the
> > > generated code to clang-format (when available). I made a simple patch
> > > for that too.
>
Hi
On Tue, Feb 28, 2023 at 7:55 PM Eric Blake wrote:
> On Tue, Feb 07, 2023 at 06:25:32PM +0400, marcandre.lur...@redhat.com
> wrote:
> > From: Marc-André Lureau
> >
> > The generated code doesn't quite handle the conditional arguments.
> > For example, 'bar' in 'test-if-cmd' is not correctly s
On Wed, Feb 22, 2023 at 11:23:03AM +0100, Markus Armbruster wrote:
> > However, I think it would be simpler, and better, if we piped the
> > generated code to clang-format (when available). I made a simple patch
> > for that too.
>
> Piping through indent or clang-format may well give us neater re
On Tue, Feb 07, 2023 at 06:25:32PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The generated code doesn't quite handle the conditional arguments.
> For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if
> conditions. See generated code in qmp_marshal_te
Hi
On Wed, Feb 22, 2023 at 2:29 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Wed, Feb 22, 2023 at 2:23 PM Markus Armbruster wrote:
> > > Another option is to always pass a dummy last argument? :)
> > >
> > > void command(first,
> > > #ifdef A
> > > a,
> > > #endif
> > > #ifdef B
> > > b,
>
Hi
On Wed, Feb 22, 2023 at 2:23 PM Markus Armbruster wrote:
> > Another option is to always pass a dummy last argument? :)
> >
> > void command(first,
> > #ifdef A
> > a,
> > #endif
> > #ifdef B
> > b,
> > #endif
> > dummy)
>
> Yet another option:
>
> void command(first
> #ifdef A
Marc-André Lureau writes:
> Hi
>
> On Mon, Feb 20, 2023 at 12:10 PM Markus Armbruster wrote:
>>
>> Marc-André Lureau writes:
>>
>> > Hi Markus
>> >
>> > On Fri, Feb 17, 2023 at 12:28 PM Markus Armbruster
>> > wrote:
>> >
>> >> marcandre.lur...@redhat.com writes:
>> >>
>> >> > From: Marc-André
Hi
On Mon, Feb 20, 2023 at 12:10 PM Markus Armbruster wrote:
>
> Marc-André Lureau writes:
>
> > Hi Markus
> >
> > On Fri, Feb 17, 2023 at 12:28 PM Markus Armbruster
> > wrote:
> >
> >> marcandre.lur...@redhat.com writes:
> >>
> >> > From: Marc-André Lureau
> >> >
> >> > The generated code doe
Marc-André Lureau writes:
> Hi Markus
>
> On Fri, Feb 17, 2023 at 12:28 PM Markus Armbruster
> wrote:
>
>> marcandre.lur...@redhat.com writes:
>>
>> > From: Marc-André Lureau
>> >
>> > The generated code doesn't quite handle the conditional arguments.
>> > For example, 'bar' in 'test-if-cmd' is
Hi Markus
On Fri, Feb 17, 2023 at 12:28 PM Markus Armbruster
wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > The generated code doesn't quite handle the conditional arguments.
> > For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if
> > condi
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> The generated code doesn't quite handle the conditional arguments.
> For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if
> conditions. See generated code in qmp_marshal_test_if_cmd().
>
> Note that if there are m
Hi Markus
On Thu, Feb 9, 2023 at 4:42 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > The generated code doesn't quite handle the conditional arguments.
> > For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if
> > conditi
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> The generated code doesn't quite handle the conditional arguments.
> For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if
> conditions. See generated code in qmp_marshal_test_if_cmd().
>
> Note that if there are m
From: Marc-André Lureau
The generated code doesn't quite handle the conditional arguments.
For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if
conditions. See generated code in qmp_marshal_test_if_cmd().
Note that if there are multiple optional arguments at the last position,
20 matches
Mail list logo
