Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-12 Thread John Levon
On Thu, Jun 12, 2025 at 08:39:17AM +0200, Cédric Le Goater wrote: > > +static void vfio_user_pci_realize(PCIDevice *pdev, Error **errp) > > +{ > > +ERRP_GUARD(); > > +VFIOUserPCIDevice *udev = VFIO_USER_PCI(pdev); > > +VFIOPCIDevice *vdev = VFIO_PCI_BASE(pdev); > > +VFIODevice *vba

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-11 Thread Cédric Le Goater
On 6/7/25 02:10, John Levon wrote: Introduce basic plumbing for vfio-user behind a new --enable-vfio-user-client option. We introduce VFIOUserContainer in hw/vfio-user/container.c, which is a container type for the "IOMMU" type "vfio-iommu-user", and share some common container code from hw/vfio

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-11 Thread John Levon
On Wed, Jun 11, 2025 at 09:46:15AM +0200, Cédric Le Goater wrote: > > > can't we simply have a CONFIG option and select the device on platforms > > > supporting it ? > > > > You mean always build vfio-user client rather than optionally? Why would it > > be > > different from other optional compo

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-11 Thread Cédric Le Goater
On 6/10/25 18:52, John Levon wrote: On Tue, Jun 10, 2025 at 11:57:00AM +0200, Cédric Le Goater wrote: @@ -529,6 +531,8 @@ _meson_option_parse() { --disable-vdi) printf "%s" -Dvdi=disabled ;; --enable-vduse-blk-export) printf "%s" -Dvduse_blk_export=enabled ;; --disable-vdus

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-10 Thread John Levon
On Tue, Jun 10, 2025 at 11:57:00AM +0200, Cédric Le Goater wrote: > > @@ -529,6 +531,8 @@ _meson_option_parse() { > > --disable-vdi) printf "%s" -Dvdi=disabled ;; > > --enable-vduse-blk-export) printf "%s" -Dvduse_blk_export=enabled ;; > > --disable-vduse-blk-export) printf "%s"

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-10 Thread Cédric Le Goater
On 6/10/25 13:42, Mark Cave-Ayland wrote: On 07/06/2025 01:10, John Levon wrote: Introduce basic plumbing for vfio-user behind a new --enable-vfio-user-client option. We introduce VFIOUserContainer in hw/vfio-user/container.c, which is a container type for the "IOMMU" type "vfio-iommu-user", a

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-10 Thread Cédric Le Goater
On 6/10/25 13:56, John Levon wrote: On Tue, Jun 10, 2025 at 12:42:35PM +0100, Mark Cave-Ayland wrote: Question: how do you see the division between hw/vfio and hw/vfio-user? My initial feeling is that there is substantial sharing between the two, in which case I'd expect the files to be in hw/v

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-10 Thread John Levon
On Tue, Jun 10, 2025 at 12:42:35PM +0100, Mark Cave-Ayland wrote: > Question: how do you see the division between hw/vfio and hw/vfio-user? My > initial feeling is that there is substantial sharing between the two, in > which case I'd expect the files to be in hw/vfio as e.g. > hw/vfio/container-u

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-10 Thread Mark Cave-Ayland
On 07/06/2025 01:10, John Levon wrote: Introduce basic plumbing for vfio-user behind a new --enable-vfio-user-client option. We introduce VFIOUserContainer in hw/vfio-user/container.c, which is a container type for the "IOMMU" type "vfio-iommu-user", and share some common container code from hw

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-10 Thread Cédric Le Goater
On 6/7/25 02:10, John Levon wrote: Introduce basic plumbing for vfio-user behind a new --enable-vfio-user-client option. We introduce VFIOUserContainer in hw/vfio-user/container.c, which is a container type for the "IOMMU" type "vfio-iommu-user", and share some common container code from hw/vfio

[PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-06 Thread John Levon
Introduce basic plumbing for vfio-user behind a new --enable-vfio-user-client option. We introduce VFIOUserContainer in hw/vfio-user/container.c, which is a container type for the "IOMMU" type "vfio-iommu-user", and share some common container code from hw/vfio/container.c. Add hw/vfio-user/pci.c