Re: [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member

2021-02-25 Thread Markus Armbruster
John Snow writes: > On 2/24/21 5:39 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Iterating over the members of data isn't going to work if it's not some >>> form of dict anyway, but for the sake of mypy, formalize it. >>> >>> Signed-off-by: John Snow >>> Reviewed-by: Eduardo Habkos

Re: [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member

2021-02-24 Thread John Snow
On 2/24/21 5:39 AM, Markus Armbruster wrote: John Snow writes: Iterating over the members of data isn't going to work if it's not some form of dict anyway, but for the sake of mypy, formalize it. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost --- scripts/qapi/expr.py | 7 +++

Re: [PATCH v3 06/16] qapi/expr.py: Check type of 'data' member

2021-02-24 Thread Markus Armbruster
John Snow writes: > Iterating over the members of data isn't going to work if it's not some > form of dict anyway, but for the sake of mypy, formalize it. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > --- > scripts/qapi/expr.py | 7 +++ > 1 file changed, 7 insertions(+) > >

[PATCH v3 06/16] qapi/expr.py: Check type of 'data' member

2021-02-22 Thread John Snow
Iterating over the members of data isn't going to work if it's not some form of dict anyway, but for the sake of mypy, formalize it. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost --- scripts/qapi/expr.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qapi/expr.py b/s