Re: [PATCH v3 06/13] qapi/parser: remove FIXME comment from _append_body_line

2021-09-30 Thread John Snow
On Thu, Sep 30, 2021 at 4:47 AM Markus Armbruster wrote: > John Snow writes: > > > True, we do not check the validity of this symbol -- but we don't check > > the validity of definition names during parse, either -- that happens > > later, during the expr check. I don't want to introduce a depen

Re: [PATCH v3 06/13] qapi/parser: remove FIXME comment from _append_body_line

2021-09-30 Thread Markus Armbruster
John Snow writes: > True, we do not check the validity of this symbol -- but we don't check > the validity of definition names during parse, either -- that happens > later, during the expr check. I don't want to introduce a dependency on > expr.py:check_name_str here and introduce a cycle. > > In

[PATCH v3 06/13] qapi/parser: remove FIXME comment from _append_body_line

2021-09-29 Thread John Snow
True, we do not check the validity of this symbol -- but we don't check the validity of definition names during parse, either -- that happens later, during the expr check. I don't want to introduce a dependency on expr.py:check_name_str here and introduce a cycle. Instead, rest assured that a docu