Re: [PATCH v3 05/20] target/mips: Move cpu_mips_get_random() with CP0 helpers

2020-10-12 Thread Luc Michel
On 22:43 Sat 10 Oct , Philippe Mathieu-Daudé wrote: > The get_random() helper uses the CP0_Wired register, which is > unrelated to the CP0_Count register use as timer. typo: used > Commit e16fe40c872 ("Move the MIPS CPU timer in a separate file") > incorrectly moved this get_random() helper wit

[PATCH v3 05/20] target/mips: Move cpu_mips_get_random() with CP0 helpers

2020-10-10 Thread Philippe Mathieu-Daudé
The get_random() helper uses the CP0_Wired register, which is unrelated to the CP0_Count register use as timer. Commit e16fe40c872 ("Move the MIPS CPU timer in a separate file") incorrectly moved this get_random() helper with timer specific code. Move it back to generic CP0 helpers. Reviewed-by: A