Re: [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types

2021-03-01 Thread Markus Armbruster
John Snow writes: > On 2/25/21 6:56 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 2/24/21 5:01 AM, Markus Armbruster wrote: John Snow writes: > mypy does not know the types of values stored in Dicts that masquerade > as objects. Help the type checker out by cons

Re: [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types

2021-02-25 Thread John Snow
On 2/25/21 6:56 AM, Markus Armbruster wrote: John Snow writes: On 2/24/21 5:01 AM, Markus Armbruster wrote: John Snow writes: mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow Re

Re: [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types

2021-02-25 Thread Markus Armbruster
John Snow writes: > On 2/24/21 5:01 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> mypy does not know the types of values stored in Dicts that masquerade >>> as objects. Help the type checker out by constraining the type. >>> >>> Signed-off-by: John Snow >>> Reviewed-by: Eduardo Habk

Re: [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types

2021-02-24 Thread John Snow
On 2/24/21 5:01 AM, Markus Armbruster wrote: John Snow writes: mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts

Re: [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types

2021-02-24 Thread Markus Armbruster
John Snow writes: > mypy does not know the types of values stored in Dicts that masquerade > as objects. Help the type checker out by constraining the type. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > --- > scripts/qapi/expr.py | 25 +++

[PATCH v3 03/16] qapi/expr.py: constrain incoming expression types

2021-02-22 Thread John Snow
mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 25 ++--- 1 file changed, 22 inse