Re: [PATCH v3 03/14] dump: Convert GuestPhysBlock iterators and use the filter functions

2022-07-21 Thread Janosch Frank
On 7/21/22 16:36, Marc-André Lureau wrote: [..] diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h index 2b39abeeae..7025e50682 100644 --- a/include/sysemu/dump.h +++ b/include/sysemu/dump.h @@ -166,11 +166,10 @@ typedef struct DumpState { hwaddr memory_offset; int fd; -G

Re: [PATCH v3 03/14] dump: Convert GuestPhysBlock iterators and use the filter functions

2022-07-21 Thread Marc-André Lureau
Hi On Thu, Jul 21, 2022 at 5:23 PM Janosch Frank wrote: > > The iteration over the memblocks is hard to understand so it's about > time to clean it up. Instead of manually grabbing the next memblock we > can use QTAILQ_FOREACH to iterate over all memblocks. > > Additionally we move the calculatio

[PATCH v3 03/14] dump: Convert GuestPhysBlock iterators and use the filter functions

2022-07-21 Thread Janosch Frank
The iteration over the memblocks is hard to understand so it's about time to clean it up. Instead of manually grabbing the next memblock we can use QTAILQ_FOREACH to iterate over all memblocks. Additionally we move the calculation of the offset and length out by using the dump_get_memblock_*() fun