Re: [PATCH v3 03/10] migration: Fix possible race when checking to_dst_file for errors

2023-08-15 Thread Peter Xu
On Fri, Aug 11, 2023 at 12:08:29PM -0300, Fabiano Rosas wrote: > diff --git a/migration/migration.c b/migration/migration.c > index 0067c927fa..85c171f32c 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -2057,11 +2057,10 @@ static int > await_return_path_close_on_source(Mig

[PATCH v3 03/10] migration: Fix possible race when checking to_dst_file for errors

2023-08-11 Thread Fabiano Rosas
Checking ms->to_dst_file for errors when cleaning up the return path could race with migrate_fd_cleanup() which clears the pointer. Since migrate_fd_cleanup() is reachable via qmp_migrate(), which is issued by the user, it is safer if we take the lock when reading ms->to_dst_file. Signed-off-by: