Re: [PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-23 Thread Daniel P . Berrangé
On Mon, Jun 23, 2025 at 08:15:16AM +0200, Markus Armbruster wrote: > Zhuoying Cai writes: > > > On 6/18/25 1:57 AM, Markus Armbruster wrote: > >> Zhuoying Cai writes: > >> > >>> On 6/17/25 6:58 AM, Markus Armbruster wrote: > Zhuoying Cai writes: > > > Add helper functions for x50

Re: [PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-23 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Jun 23, 2025 at 08:15:16AM +0200, Markus Armbruster wrote: [...] >> Use plain C enums when practical. >> >> Reasons for making a type a QAPI type include: >> >> * Some QAPI command or event needs it. >> >> * Something (typically QOM property accessors) ne

Re: [PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-23 Thread Markus Armbruster
Zhuoying Cai writes: > On 6/18/25 1:57 AM, Markus Armbruster wrote: >> Zhuoying Cai writes: >> >>> On 6/17/25 6:58 AM, Markus Armbruster wrote: Zhuoying Cai writes: > Add helper functions for x509 certificate which will be used in the next > patch for the certificate store. >

Re: [PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-18 Thread Zhuoying Cai
On 6/18/25 1:57 AM, Markus Armbruster wrote: > Zhuoying Cai writes: > >> On 6/17/25 6:58 AM, Markus Armbruster wrote: >>> Zhuoying Cai writes: >>> Add helper functions for x509 certificate which will be used in the next patch for the certificate store. Signed-off-by: Zhuoying

Re: [PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-17 Thread Markus Armbruster
Zhuoying Cai writes: > On 6/17/25 6:58 AM, Markus Armbruster wrote: >> Zhuoying Cai writes: >> >>> Add helper functions for x509 certificate which will be used in the next >>> patch for the certificate store. >>> >>> Signed-off-by: Zhuoying Cai [...] >> Ignorant question: why are these QAPI

Re: [PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-17 Thread Zhuoying Cai
On 6/17/25 6:58 AM, Markus Armbruster wrote: > Zhuoying Cai writes: > >> Add helper functions for x509 certificate which will be used in the next >> patch for the certificate store. >> >> Signed-off-by: Zhuoying Cai > > [...] > >> diff --git a/qapi/crypto.json b/qapi/crypto.json >> index c9

Re: [PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-17 Thread Markus Armbruster
Zhuoying Cai writes: > Add helper functions for x509 certificate which will be used in the next > patch for the certificate store. > > Signed-off-by: Zhuoying Cai [...] > diff --git a/qapi/crypto.json b/qapi/crypto.json > index c9d967d782..af487dcecd 100644 > --- a/qapi/crypto.json > +++ b/qap

Re: [PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-06 Thread Daniel P . Berrangé
On Wed, Jun 04, 2025 at 05:56:30PM -0400, Zhuoying Cai wrote: > Add helper functions for x509 certificate which will be used in the next > patch for the certificate store. > > Signed-off-by: Zhuoying Cai > --- > crypto/meson.build | 5 +- > crypto/x509-utils.c | 166 ++

Re: [PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-06 Thread Daniel P . Berrangé
On Wed, Jun 04, 2025 at 05:56:30PM -0400, Zhuoying Cai wrote: > Add helper functions for x509 certificate which will be used in the next > patch for the certificate store. > > Signed-off-by: Zhuoying Cai > --- > crypto/meson.build | 5 +- > crypto/x509-utils.c | 166 ++

[PATCH v3 02/28] crypto/x509-utils: Add helper functions for certificate store

2025-06-04 Thread Zhuoying Cai
Add helper functions for x509 certificate which will be used in the next patch for the certificate store. Signed-off-by: Zhuoying Cai --- crypto/meson.build | 5 +- crypto/x509-utils.c | 166 include/crypto/x509-utils.h | 54