Re: [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2021-03-01 Thread Markus Armbruster
John Snow writes: > On 2/25/21 5:40 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 2/24/21 4:30 AM, Markus Armbruster wrote: John Snow writes: > OrderedDict is a subtype of dict, so we can check for a more general > form. These functions do not themselves depend

Re: [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2021-02-25 Thread John Snow
On 2/25/21 5:40 AM, Markus Armbruster wrote: John Snow writes: On 2/24/21 4:30 AM, Markus Armbruster wrote: John Snow writes: OrderedDict is a subtype of dict, so we can check for a more general form. These functions do not themselves depend on it being any particular type. True. The ac

Re: [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2021-02-25 Thread Markus Armbruster
John Snow writes: > On 2/24/21 4:30 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> OrderedDict is a subtype of dict, so we can check for a more general >>> form. These functions do not themselves depend on it being any >>> particular type. >> >> True. The actual arguments can only b

Re: [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2021-02-24 Thread John Snow
On 2/24/21 4:30 AM, Markus Armbruster wrote: John Snow writes: OrderedDict is a subtype of dict, so we can check for a more general form. These functions do not themselves depend on it being any particular type. True. The actual arguments can only be OrderedDict, though. I think we refrain

Re: [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2021-02-24 Thread Markus Armbruster
John Snow writes: > OrderedDict is a subtype of dict, so we can check for a more general > form. These functions do not themselves depend on it being any > particular type. True. The actual arguments can only be OrderedDict, though. I think we refrained from relaxing to dict in these helpers b

[PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2021-02-22 Thread John Snow
OrderedDict is a subtype of dict, so we can check for a more general form. These functions do not themselves depend on it being any particular type. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 5 ++--- 1 file changed, 2 insertions(+