Re: [PATCH v3 01/10] migration: Fix possible race when setting rp_state.error

2023-08-15 Thread Peter Xu
On Fri, Aug 11, 2023 at 12:08:27PM -0300, Fabiano Rosas wrote: > We don't need to set the rp_state.error right after a shutdown because > qemu_file_shutdown() always sets the QEMUFile error, so the return > path thread would have seen it and set the rp error itself. > > Setting the error outside o

[PATCH v3 01/10] migration: Fix possible race when setting rp_state.error

2023-08-11 Thread Fabiano Rosas
We don't need to set the rp_state.error right after a shutdown because qemu_file_shutdown() always sets the QEMUFile error, so the return path thread would have seen it and set the rp error itself. Setting the error outside of the thread is also racy because the thread could clear it after we set