Re: [PATCH v3 0/7] hugetlbfs memory HW error fixes

2024-12-09 Thread David Hildenbrand
On 06.12.24 19:26, William Roche wrote: On 12/3/24 16:00, David Hildenbrand wrote: On 03.12.24 15:39, William Roche wrote: [...] Our new Qemu code is testing first the fallocate+MADV_DONTNEED procedure for standard sized pages (in ram_block_discard_range()) and only folds back to the mmap() use

Re: [PATCH v3 0/7] hugetlbfs memory HW error fixes

2024-12-06 Thread William Roche
On 12/3/24 16:00, David Hildenbrand wrote: On 03.12.24 15:39, William Roche wrote: [...] Our new Qemu code is testing first the fallocate+MADV_DONTNEED procedure for standard sized pages (in ram_block_discard_range()) and only folds back to the mmap() use if it fails. So maybe my proposal to imp

Re: [PATCH v3 0/7] hugetlbfs memory HW error fixes

2024-12-03 Thread David Hildenbrand
On 03.12.24 15:39, William Roche wrote: On 12/3/24 15:08, David Hildenbrand wrote: [...] Let me take a look at your tool below if I can find an explanation of what is happening, because it's weird :) [...] At the end of this email, I included the source code of a simplistic test case that s

Re: [PATCH v3 0/7] hugetlbfs memory HW error fixes

2024-12-03 Thread William Roche
On 12/3/24 15:08, David Hildenbrand wrote: [...] Let me take a look at your tool below if I can find an explanation of what is happening, because it's weird :) [...] At the end of this email, I included the source code of a simplistic test case that shows that the page is replaced in the c

Re: [PATCH v3 0/7] hugetlbfs memory HW error fixes

2024-12-03 Thread David Hildenbrand
On 03.12.24 01:15, William Roche wrote: On 12/2/24 17:00, David Hildenbrand wrote: On 02.12.24 16:41, William Roche wrote: Hello David, Hi, sorry for reviewing yet, I was rather sick the last 1.5 weeks. I hope you get well soon! Getting there, thanks! :) I've finally tested many page

Re: [PATCH v3 0/7] hugetlbfs memory HW error fixes

2024-12-02 Thread William Roche
On 12/2/24 17:00, David Hildenbrand wrote: On 02.12.24 16:41, William Roche wrote: Hello David, Hi, sorry for reviewing yet, I was rather sick the last 1.5 weeks. I hope you get well soon! I've finally tested many page mapping possibilities and tried to identify the error injection reacti

Re: [PATCH v3 0/7] hugetlbfs memory HW error fixes

2024-12-02 Thread William Roche
Hello David, I've finally tested many page mapping possibilities and tried to identify the error injection reaction on these pages to see if mmap() can be used to recover the impacted area. I'm using the latest upstream kernel I have for that: 6.12.0-rc7.master.20241117.ol9.x86_64 But I also g

Re: [PATCH v3 0/7] hugetlbfs memory HW error fixes

2024-12-02 Thread David Hildenbrand
On 02.12.24 16:41, William Roche wrote: Hello David, Hi, sorry for reviewing yet, I was rather sick the last 1.5 weeks. I've finally tested many page mapping possibilities and tried to identify the error injection reaction on these pages to see if mmap() can be used to recover the impacted

[PATCH v3 0/7] hugetlbfs memory HW error fixes

2024-11-25 Thread “William Roche
From: William Roche Hi David, Here is an new version of our code, but I still need to double check the mmap behavior in case of a memory error impact on: - a clean page of an empty file or populated file - already mapped using MAP_SHARED or MAP_PRIVATE to see if mmap() can recover the area or no