Re: [PATCH v3 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-09-17 Thread Stefan Hajnoczi
On Tue, Sep 17, 2024 at 09:05:34AM +0200, Albert Esteve wrote: > On Mon, Sep 16, 2024 at 7:57 PM Stefan Hajnoczi wrote: > > > This patch series could use tests. The first two patches seem broken and > > testing would have revealed that the memory allocation and pointers are > > not quite right. >

Re: [PATCH v3 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-09-17 Thread Albert Esteve
On Mon, Sep 16, 2024 at 7:57 PM Stefan Hajnoczi wrote: > This patch series could use tests. The first two patches seem broken and > testing would have revealed that the memory allocation and pointers are > not quite right. > My bad. Previous version of the patch I did test with a device that I'v

Re: [PATCH v3 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-09-16 Thread Stefan Hajnoczi
This patch series could use tests. The first two patches seem broken and testing would have revealed that the memory allocation and pointers are not quite right. One testing approach is to write a test device using libvhost-user that exposes VIRTIO Shared Memory Regions, launch QEMU in qtest mode

Re: [PATCH v3 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-09-12 Thread Albert Esteve
Link to the documentation: https://lore.kernel.org/all/20240912144432.126717-1-aest...@redhat.com/T/#t On Thu, Sep 12, 2024 at 4:53 PM Albert Esteve wrote: > Hi all, > > v2->v3: > - Add track for mapped memory in VIRTIO > Shared memory regions, so that boundaries > can be verified when a req

[PATCH v3 0/5] vhost-user: Add SHMEM_MAP/UNMAP requests

2024-09-12 Thread Albert Esteve
Hi all, v2->v3: - Add track for mapped memory in VIRTIO Shared memory regions, so that boundaries can be verified when a request for new mmap is received - Use address_space_read/write() for MEM_READ/_WRITE handling methods. - Improve/fix support for flexible array members for MEM_READ/_