Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-09-10 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 08:45:40PM +0800, BillXiang wrote: > From: BillXiang > > Currently, we have added VHOST_USER_SET_LOG_BASE to > vhost_user_per_device_request in commit 7c211eb078c4 > ("vhost-user: Skip unnecessary duplicated VHOST_USER_SET_LOG_BASE requests"), > as a result, VHOST_USER_

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-27 Thread Michael S. Tsirkin
On Tue, Aug 27, 2024 at 09:00:35PM +0800, BillXiang wrote: > > > From: "Prasad Pandit" > > Date:  Tue, Aug 27, 2024, 20:37 > > Subject:  Re: [PATCH v3] vhost-user: Do not wait for reply for not sent > > VHOST_USER_SET_LOG_BASE > > To: "BillXiang&qu

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-27 Thread BillXiang
> From: "Prasad Pandit" > Date:  Tue, Aug 27, 2024, 20:37 > Subject:  Re: [PATCH v3] vhost-user: Do not wait for reply for not sent > VHOST_USER_SET_LOG_BASE > To: "BillXiang" > Cc: "Michael S. Tsirkin", > On Tue, 27 Aug 2024 at 16:50, BillXi

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-27 Thread Prasad Pandit
On Tue, 27 Aug 2024 at 16:50, BillXiang wrote: > it's better to be consistent to use vhost_user_per_device_request for those > per-device messages, right? * ...consistent to use? Could you please elaborate a little? Thank you. --- - Prasad

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-27 Thread BillXiang
> From: "Prasad Pandit" > Date:  Tue, Aug 27, 2024, 19:06 > Subject:  Re: [PATCH v3] vhost-user: Do not wait for reply for not sent > VHOST_USER_SET_LOG_BASE > To: "BillXiang" > Cc: "Michael S. Tsirkin", > On Thu, 1 Aug 2024 at 20:32

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-27 Thread Prasad Pandit
On Thu, 1 Aug 2024 at 20:32, BillXiang wrote: > > From: "Michael S. Tsirkin" > > How do things work now after 7c211eb078c4 then? > > It does not really work after 7c211eb078c4 and it's my mistake. > I forgot to submit the code to check vq_index in 7c211eb078c4. > * vhost_user_set_log_base() sends

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-01 Thread BillXiang
> From: "Michael S. Tsirkin" > Date:  Thu, Aug 1, 2024, 22:13 > Subject:  Re: [PATCH v3] vhost-user: Do not wait for reply for not sent > VHOST_USER_SET_LOG_BASE > To: "BillXiang" > Cc: > On Thu, Aug 01, 2024 at 08:45:40PM +0800, BillXiang wrote: &g

Re: [PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 08:45:40PM +0800, BillXiang wrote: > From: BillXiang > > Currently, we have added VHOST_USER_SET_LOG_BASE to > vhost_user_per_device_request in commit 7c211eb078c4 > ("vhost-user: Skip unnecessary duplicated VHOST_USER_SET_LOG_BASE requests"), > as a result, VHOST_USER_

[PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-01 Thread BillXiang
From: BillXiang Currently, we have added VHOST_USER_SET_LOG_BASE to vhost_user_per_device_request in commit 7c211eb078c4 ("vhost-user: Skip unnecessary duplicated VHOST_USER_SET_LOG_BASE requests"), as a result, VHOST_USER_SET_LOG_BASE will be sent only once when 'vq_index == 0'. In this patc