Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread Jason A. Donenfeld
On Tue, Aug 02, 2022 at 05:32:26PM +0200, David Hildenbrand wrote: > On 02.08.22 17:28, Jason A. Donenfeld wrote: > > Hi David, Christian, > > > > While this thread has your attention, I thought I'd reiterate my offer in: > > https://lore.kernel.org/qemu-devel/yueouwzdzbqff...@zx2c4.com/ > > > >

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread Jason A. Donenfeld
On Wed, Jul 20, 2022 at 02:08:59PM +0200, Jason A. Donenfeld wrote: > +case 114: > +if (r1 & 1 || !r1 || r2 & 1 || !r2) > +tcg_s390_program_interrupt(env, PGM_SPECIFICATION, ra); This is already handled in op_msa. I'm going to remove it for v4.

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread David Hildenbrand
On 02.08.22 17:28, Jason A. Donenfeld wrote: > Hi David, Christian, > > While this thread has your attention, I thought I'd reiterate my offer in: > https://lore.kernel.org/qemu-devel/yueouwzdzbqff...@zx2c4.com/ > > Do either of you want to "take ownership" of this patch to bring it > past the fi

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread Jason A. Donenfeld
Hi David, Christian, While this thread has your attention, I thought I'd reiterate my offer in: https://lore.kernel.org/qemu-devel/yueouwzdzbqff...@zx2c4.com/ Do either of you want to "take ownership" of this patch to bring it past the finish line, and I can provide whatever additional crypto cod

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread David Hildenbrand
On 02.08.22 17:15, Christian Borntraeger wrote: > > > Am 02.08.22 um 16:53 schrieb David Hildenbrand: >> On 02.08.22 16:01, Christian Borntraeger wrote: >>> >>> >>> Am 02.08.22 um 15:54 schrieb David Hildenbrand: On 02.08.22 15:26, Christian Borntraeger wrote: > > > Am 20.07.22 u

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread Christian Borntraeger
Am 02.08.22 um 16:53 schrieb David Hildenbrand: On 02.08.22 16:01, Christian Borntraeger wrote: Am 02.08.22 um 15:54 schrieb David Hildenbrand: On 02.08.22 15:26, Christian Borntraeger wrote: Am 20.07.22 um 14:08 schrieb Jason A. Donenfeld: In order for hosts running inside of TCG to i

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread David Hildenbrand
On 02.08.22 16:01, Christian Borntraeger wrote: > > > Am 02.08.22 um 15:54 schrieb David Hildenbrand: >> On 02.08.22 15:26, Christian Borntraeger wrote: >>> >>> >>> Am 20.07.22 um 14:08 schrieb Jason A. Donenfeld: In order for hosts running inside of TCG to initialize the kernel's rando

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread Christian Borntraeger
Am 02.08.22 um 15:54 schrieb David Hildenbrand: On 02.08.22 15:26, Christian Borntraeger wrote: Am 20.07.22 um 14:08 schrieb Jason A. Donenfeld: In order for hosts running inside of TCG to initialize the kernel's random number generator, we should support the PRNO_TRNG instruction, backed

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread David Hildenbrand
On 02.08.22 15:26, Christian Borntraeger wrote: > > > Am 20.07.22 um 14:08 schrieb Jason A. Donenfeld: >> In order for hosts running inside of TCG to initialize the kernel's >> random number generator, we should support the PRNO_TRNG instruction, >> backed in the usual way with the qemu_guest_get

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-08-02 Thread Christian Borntraeger
Am 20.07.22 um 14:08 schrieb Jason A. Donenfeld: In order for hosts running inside of TCG to initialize the kernel's random number generator, we should support the PRNO_TRNG instruction, backed in the usual way with the qemu_guest_getrandom helper. This is confirmed working on Linux 5.19-rc6.

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-07-27 Thread Jason A. Donenfeld
Hey Thomas, On Wed, Jul 27, 2022 at 08:32:22AM +0200, Thomas Huth wrote: > On 27/07/2022 03.35, Jason A. Donenfeld wrote: > > Hey David, > > > > On Wed, Jul 20, 2022 at 08:41:48PM +0200, David Hildenbrand wrote: > >> I did not review the doc in detail once again, maybe I get to that later > >> th

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-07-26 Thread Thomas Huth
On 27/07/2022 03.35, Jason A. Donenfeld wrote: Hey David, On Wed, Jul 20, 2022 at 08:41:48PM +0200, David Hildenbrand wrote: I did not review the doc in detail once again, maybe I get to that later this week. Did you ever get around to merging this patch? Is it in some tree somewhere? QEMU

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-07-26 Thread Jason A. Donenfeld
Hey David, On Wed, Jul 20, 2022 at 08:41:48PM +0200, David Hildenbrand wrote: > I did not review the doc in detail once again, maybe I get to that later > this week. Did you ever get around to merging this patch? Is it in some tree somewhere? Jason

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-07-20 Thread Jason A. Donenfeld
Hi David, On Wed, Jul 20, 2022 at 08:41:48PM +0200, David Hildenbrand wrote: > > +while (len) { > > +size_t block = MIN(len, sizeof(tmp)); > > + > > +qemu_guest_getrandom_nofail(tmp, block); > > +for (size_t i = 0; i < block; ++i) { > > +

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-07-20 Thread David Hildenbrand
On 20.07.22 14:08, Jason A. Donenfeld wrote: > In order for hosts running inside of TCG to initialize the kernel's > random number generator, we should support the PRNO_TRNG instruction, > backed in the usual way with the qemu_guest_getrandom helper. This is > confirmed working on Linux 5.19-rc6. >

[PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-07-20 Thread Jason A. Donenfeld
In order for hosts running inside of TCG to initialize the kernel's random number generator, we should support the PRNO_TRNG instruction, backed in the usual way with the qemu_guest_getrandom helper. This is confirmed working on Linux 5.19-rc6. Cc: Thomas Huth Cc: David Hildenbrand Cc: Richard H