Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-07 Thread Markus Armbruster
Markus Armbruster writes: > Simran Singhal writes: > >> Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0" >> to fix the typo. >> >> Fixes: 8d3265b3 >> >> Reviewed-by: Eric Blake >> Signed-off-by: Simran Singhal > > First, thank you so much for spotting and fixing my typo! >

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread Markus Armbruster
Simran Singhal writes: > Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0" > to fix the typo. > > Fixes: 8d3265b3 > > Reviewed-by: Eric Blake > Signed-off-by: Simran Singhal First, thank you so much for spotting and fixing my typo! The commit message neglects to explain wh

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count Message-id: 20200402182848.GA3023

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash exp

Re: [PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402182848.GA3023@simran-Inspiron-5558/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit th

[PATCH v3] qobject: json-streamer: Change bracket_count to brace_count

2020-04-02 Thread Simran Singhal
Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0" to fix the typo. Fixes: 8d3265b3 Reviewed-by: Eric Blake Signed-off-by: Simran Singhal --- Changes in v3: -Add "Fixes: 8d3265b3" in commit message. Changes in v2: -No need to remove the duplicate occurrence o